Skip to content

Conversation

@ariesdevil
Copy link
Contributor

@ariesdevil ariesdevil commented Dec 24, 2025

Why?

Add UNION and NONE to type ids that align with xlang spec

What does this PR do?

This PR adds UNION and NONE to type ids:

  1. add UNION and NONE to type ids
  2. change () and PhantomData type id from UNKNOWN to NONE
  3. skip early when encounter NONE in skip_any_value

Related issues

None

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
    • Yes, adds new public types support: UNION and NONE to TypeId
  • Does this PR introduce any binary protocol compatibility change?
    • No

Benchmark

Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit 910b565 into apache:main Dec 24, 2025
52 checks passed
@ariesdevil ariesdevil deleted the feat/add-union-none-support branch December 24, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants