Refine performance #1490
Closed
Refine performance #1490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstamas
reviewed
Jun 14, 2025
|
|
||
| hashCode = Objects.hash(artifact, repositories, selector, manager, traverser, filter); | ||
| hashCode = | ||
| Objects.hash(artifact, repositories, selector, System.identityHashCode(manager), traverser, filter); |
Member
There was a problem hiding this comment.
identityHashCode is wrong here: what we want in fact is "state" of manager (ie. "same conditions for same artifacts gives same siblings").
Author
There was a problem hiding this comment.
If so, then this pr shall be re-designed.
sigh.
If really wanna keep a state of the manager, then we have to analyze if the hashing process can be splited/re-used, which is very complicated then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refine performance for demo at apache/maven#2481
special warning:
I'm not familiar with your DataPool key design, I just see the codes about it and think we can use that identity-hash there instead, because the hashing be too slow.
So if that can never be replaced to identity hash actually, please just tell me the reason, I would like to help with some other strategy...
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.