Drop Holder from depMgr #1504
Closed
Drop Holder from depMgr #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it make no sense: depMgr holds "applicable" information in own state, while Holder added extra layer of "depth" info. Basically Holder and depMgr instance itself were redundant.
Member
Author
|
This is wrong: makes IT MavenITmng8347TransitiveDependencyManagerTest fail (that in fact covers this exact spot). The assessment "is redundant" is wrong. There is more to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it make no sense: depMgr holds "applicable" information in own state, while Holder added extra layer of "depth" info. Basically Holder and depMgr instance itself were redundant to each other.