HDDS-11756. Trigger test failure if new scanner failure types are added without tests #9184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The FailureType enum is used to indicate what type of issue the scanner saw. TestContainerCorruptions also provides an enum for injecting different types of failures into tests. The two are separate since some FailureTypes may be hit with multiple paths, each identified by a unique entry in TestContainerCorruptions
As suggested in this comment, introduced a test to trigger a test failure if a new FailureType is added (expanding the functionality of the scanner) but no corresponding test is added. This may mean making the two enums more tightly coupled.
What is the link to the Apache JIRA
HDDS-11756
How was this patch tested?
Added
TestFailureTypeCoverage.Test fails if a
FailureTypedoes not have a corresponding test or is not explicitly excluded.