HDDS-13822. Add regression testing for OM epoch and txId calculation #9188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivandika3
reviewed
Oct 23, 2025
| } | ||
| } | ||
|
|
||
| // Regression tests for OM epoch and txld calculation methods |
There was a problem hiding this comment.
Nit: Let's remove this comment.
Comment on lines
330
to
338
| long validTxId = OmUtils.MAX_TRXN_ID; | ||
| // Test valid case - should not throw exception | ||
| try { | ||
| OmUtils.getObjectIdFromTxId(2, validTxId); | ||
| } catch (Exception e) { | ||
| fail("Valid txId should not throw exception: " + e.getMessage()); | ||
| } | ||
|
|
||
| long invalidTxId = OmUtils.MAX_TRXN_ID + 1; |
There was a problem hiding this comment.
Let's use the actual value instead of taking from OmUtils.MAX_TRXN_ID
peterxcli
reviewed
Oct 23, 2025
| String serviceId = "myOmId"; | ||
|
|
||
| conf.set(OZONE_OM_NODES_KEY + "." + serviceId, "omA,omB,omC"); | ||
| conf.set(OZONE_OM_NODES_KEY + "." + serviceId, "omA,omB,omC"); |
|
|
||
| String serviceId2 = "myOmId2"; | ||
| conf.set(OZONE_OM_NODES_KEY + "." + serviceId2, "om1"); | ||
| conf.set(OZONE_OM_NODES_KEY + "." + serviceId2, "om1"); |
|
@ivandika3 , @peterxcli thanks a lot for your feedback!!! I've made changes. |
|
@rich7420 the checkstyle is still failing: https://github.com/rich7420/ozone/actions/runs/18740162208/job/53454664804 |
|
@ivandika3 thanks for your reminding! I've solved the check style error. |
|
@rich7420 Thanks for the update. Looks like |
This reverts commit b39bbc3.
rich7420
force-pushed
the
HDDS-13822-test
branch
from
dffc3f5 to
ea60cf4
Compare
ivandika3
reviewed
Oct 31, 2025
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java
Outdated
Show resolved
Hide resolved
ivandika3
approved these changes
Nov 1, 2025
|
@ivandika3 thanks a lot for your suggestions! |
|
Thanks @rich7420 for the patch and @peterxcli for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes adding regression tests for the OmUtils class in Apache Ozone. These tests ensure that critical methods handling OM epoch and transaction ID (txId) calculations (specifically getOMEpoch, getObjectIdFromTxId, addEpochToTxId, and getTxIdFromObjectId) maintain their expected behavior and don't introduce regressions with future code changes.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13822
How was this patch tested?