HDDS-12133. Define replication metrics task names and descriptions as constants to reuse in CommandHandler #9215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constants to reuse in CommandHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently the commands that go through the replication supervisor are getting the name of the metrics from the task to retrieve from the supervisor, and this may be null if no task has been submitted yet. This results in many null checks in the code.
To solve this the the metrics name and description can be defined as static constants by the task so they can be retrieved directly without null checks.
What is the link to the Apache JIRA
HDDS-12133
How was this patch tested?
Green CI : https://github.com/sreejasahithi/ozone/actions/runs/18874231291