HDDS-13137. Specify which roles need to be stopped for repair on per command basis #9217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvekshayr
reviewed
Oct 29, 2025
There was a problem hiding this comment.
Thanks for working on this @sreejasahithi.
It would be good to update the command description in the doc as well - hadoop-hdds/docs/content/tools/Repair.md
Please find my comments inline:
.../main/java/org/apache/hadoop/ozone/repair/datanode/schemaupgrade/UpgradeContainerSchema.java
Outdated
Show resolved
Hide resolved
...op-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/ldb/RocksDBManualCompaction.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/quota/QuotaRepair.java
Outdated
Show resolved
Hide resolved
sarvekshayr
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the help message of
ozone repairspecifies that the nodes being repaired must be stopped. But there are some commands which need nodes to be up and running as they communicate with the servers.The help messages of each of the repair command must specify which nodes need to be up or stopped. And the help message of
ozone repairshouldn't specify any direction about the same.What is the link to the Apache JIRA
HDDS-13137
How was this patch tested?
https://github.com/sreejasahithi/ozone/actions/runs/18864116730