HDDS-13852. Remove dependency on HDDSLayout for OM to SCM request #9219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyeshkaratha
force-pushed
the
HDDS-13852
branch
from
19f75e0 to
c0f26fb
Compare
Contributor
Author
|
@ChenSammi @sumitagrawl can you review the code changes? |
Contributor
Author
|
closing this PR since the approach for passing size info changed and handled as part of #9246 |
Contributor
|
@priyeshkaratha can you please also resolve the Jira issue, if no longer planned to be implemented? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the
deleteBlockrequest, the OM now sends both theblockSizeandblockIDto the SCM. Since this introduces a change in the request format, it may lead to compatibility issues during upgrades.To handle this, multiple checks have been added based on the feature finalization state. The system dynamically selects the appropriate logic depending on whether the feature is finalized or not.
We have decided to proceed with the new request format. If the SCM receives a request in the old format, it will be rejected at the server-side Protobuf translator layer. As a result, block deletion operations will not be supported during upgrade scenarios.
What is the link to the Apache JIRA
HDDS-13852
How was this patch tested?
Tested with CI