-
Notifications
You must be signed in to change notification settings - Fork 328
Prep: Site for 1.2 release #2877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dimas-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: DO NOT MERGE - mark the PR as "draft"?
site/content/downloads/_index.md
Outdated
| The realm-level feature flag `ALLOW_SETTING_SUB_CATALOG_RBAC_FOR_FEDERATED_CATALOGS` (default: true) controls whether this functionality can be enabled or modified at the catalog level. | ||
| - Added support for S3-compatible storage that does not have STS (use `stsUavailable: true` in catalog storage configuration) | ||
| - Added a Management API endpoint to reset principal credentials, controlled by the `ENABLE_CREDENTIAL_RESET` (default: true) feature flag. | ||
| - Added AWS CloudWatch Event Sink Implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to flag this as "beta"? If so, I think we can do that without re-releasing 1.2.0.
I do not recall if we discussed this before, so apologies for rocking the boat. Cf. https://lists.apache.org/thread/yx7pkgczl6k7bt4k4yzqrrq9gn7gqk2p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can update the release notes in the website if we have concencus ? (post this pr as well, wdyt ?) we did that for 1.1 release
why do we wanna call it as beta though ? is it the interface gonna change or something ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dimas-b, could you elaborate the reason here? I'm not sure I understanding the reason behind beta label and re-releasing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for "beta" is in the ML thread (linked above)... TL;DR: possible changes to binary / JSON representation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're ok flagging persisted events as "beta" we could do this in the docs / release notes on the site, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also support flagging events as beta.
For a few reasons:
- The API is still evolving, see this ML thread: https://lists.apache.org/thread/rl5cpcft16sn5n00mfkmx9ldn3gsqtfy
- As the ML thread linked above shows, the SQL schema of the events table could evolve and require SQL migration.
- Existing listeners are both incomplete:
- JDBC: only processes
after-create-table,after-create-catalogevents, other events are ignored. - CloudWatch: only processes
after-refresh-tableevents, other events are ignored.
- JDBC: only processes
As I already suggested a few times, a complete, general-purpose, production-ready event listener must either process all events equally, or expose a configuration option to select which events to process or ignore. See #2630 and #2836 (comment) for more discussions on this specific topic.
For all the above reasons, I think it would be nicer for our users to mark the events feature as beta/experimental, so that they don't accidentally rely on it prematurely in production-critical deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another point for "beta": the current Polaris Evolution doc has stronger guarantees for persisted data than for java interfaces.
If events only had a java representation, it would be not necessary to flag them as "beta" now. However, given that events are persisted and their representation in the Polaris database is very likely to change per dev ML discussions, I think we ought to warn uses about foreseeable upgrade issues in this area with the help of the "beta" label (plus some brief explanation of the issue).
CC: @jbonofre : related to you comment in the main thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev ML discussion: https://lists.apache.org/thread/xogjyozb7qqj5jjs330f5s6lw69ldptv
|
heads up vote passed in IPMC :) |
|
FYI: Hugo build is broken (on |
is it due to merging 1.2 in versioned-docs branch ? i just copied the in-dev/unreleased to release/1.2.0, hmm, any pointers ? |
|
I'll start a dev ML thread... looks like a general CI issue 🤔 |
|
@singhpk234 : actually, I guess #2879 broke this... Would you mind rolling it back for now and we can redo it with more caution later? -- #2881 |
Yeah, we need to use relative paths for them |
jbonofre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced we should absolutely flagged any feature as beta. I'm more in favor of informing the community it's available, and fix/improve in next releases if needed.
If it works, it works as it is today (that's the purpose of open source projects).
But then we need to deal with angry users, we've seen this already: #2671. I think being open and honest about the state of Polaris features is key in building a trust relationship with the community. For the events feature in particular, I think it's highly likely it will change substantially in the future. |
#2671 was caused due to a bug IMHO, which made user upgrade from 1.0.1 to 1.1.0 fail even without schema version upgrade. we do need to provide some automation for schema version upgrades !
Agree with you on this ! but where are we being dishonest ? we are just saying hey this is something we have, try it out if you want to, if we put out a breaking change we should call it out in our release docs, reconsider that there is users using it and make change accordingly and this is true for any features we ship. If the rationale is there is going to be breaking change for sure regarding events and the community agrees to (which my understanding is what your and @dimas-b feedback is). I propose i remove the CloudWatch sink from the release notes entirely (this will make this feature like NoSQL where parts of code is checked in but not complete / ready) and if we want we can mark CloudWatch sink or the whole EventListner in general as beta in the follow-up when we have concencus on thread @dimas-b started. We already have release artifacts published in maven https://mvnrepository.com/artifact/org.apache.polaris/polaris-core as of (10/23), It would be great to move forward with this PR. Please let me know your thoughts ? |
The above is not dishonest per se, but it's omitting two important messages:
AFAIK, both sinks (CloudWatch and SQL) are being introduced in 1.2. Regardless of any mention in the changelog, this means that if we don't mark the API experimental now, they will be implicitly released as production-ready. It would be strange to downgrade this API from production-ready to beta in a future release imho. |
|
I think we should try to make a complete message in the 1.2.0 docs / release notes upfront, reflecting the current status of features (specifically related to events). Updating these notices after they get published should be avoided from my POV, especially since we know about potential issues already. Let's reach consensus on ML, and then revision the RNs: https://lists.apache.org/thread/xogjyozb7qqj5jjs330f5s6lw69ldptv |
b51bcc1 to
bbc7f81
Compare
flyrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @singhpk234!
|
As recommended flagged Events added additional notes on events getting dropped. I have used word please take another pass @dimas-b @adutra @jbonofre when you get some time. |
site/content/downloads/_index.md
Outdated
| - **Events Persistence (Preview)**: Introduced new event types and added support for persisting events to both Relational JDBC Persistence and AWS CloudWatch. | ||
|
|
||
| **Note**: This is a preview feature. The persistence schema is subject to change in future releases, and previously stored event data MAY become unreadable (i.e., dropped) after an upgrade. | ||
| - Generate Request IDs (if not specified) for all incoming requests to Polaris. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatic ID generation is removed by #2914 (assuming it gets merged).
I believe we should mention this as a "preview" too, and make a note that is may be removed in the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not mind removing the Generate Request IDs point from the list of features completely. Per email discussion linked from #2914 it was not really intended to be a user-level feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats make sense, i think the general concecus as per linked is to use Quarkus OTEL ! I removed the auto request id generation
|
The text about events LGTM 👍 |
Preps the website for the 1.2 release notes and artifact yet to be published
Update (10/24): The artifacts have been released as of yesterday