Build: GitInfo function to build a raw github content URL
#2910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Depends on #2908 |
snazy
force-pushed
the
gitinfo-raw-github
branch
from
0d5f0c2 to
ece71c2
Compare
adutra
approved these changes
Oct 29, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
approved these changes
Oct 29, 2025
| } | ||
| else "" | ||
| val gitInfo = GitInfo(gitHead, gitDescribe) | ||
| val rawLinkRef = if (isRelease) gitDescribe else "HEAD" |
Contributor
There was a problem hiding this comment.
nit: why not use gitDescribe for non-releases? HEAD in GH may be off with respect to the current state of the code during build 🤔
Member
Author
There was a problem hiding this comment.
it potentially says 'abcdef-dirty' (not resolvable) - and the commit may not be in the apache/polaris repo
Contributor
There was a problem hiding this comment.
Does it matter that the commit is not in GH for not released code?
Member
Author
There was a problem hiding this comment.
Yea - the link would be wrong and put in some relevant fields.
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
vchag
pushed a commit
to vchag/polaris
that referenced
this pull request
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.