fix add netty-resolver-dns-native-macos dependency to avoid DNS resolution failure on macOS #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ution failure on macOS
wu-sheng
reviewed
Nov 18, 2025
Comment on lines
+37
to
+42
| <dependency> | ||
| <groupId>io.netty</groupId> | ||
| <artifactId>netty-resolver-dns-native-macos</artifactId> | ||
| <classifier>osx-aarch_64</classifier> | ||
| <version>4.1.114.Final</version> | ||
| </dependency> |
Member
There was a problem hiding this comment.
Our tests are not locked in macOS. I have doubts about this fix. This dependency is really required, should only be used in the package in MacOS, not always.
Member
|
You could use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running test cases on macOS, an error occurs with the following message:
"Unable to load io.netty.resolver.dns.macos.MacOSDnsServerAddressStreamProvider, fallback to system defaults. This may result in incorrect DNS resolutions on macOS. Check whether you have a dependency on 'io.netty:netty-resolver-dns-native-macos'."
This commit is intended to fix this error.
CHANGESlog.