[SPARK-54201][Geo][SQL] Allow casting from GeographyType(srid) to GeographyType(ANY) #52906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
uros-db
commented
Nov 6, 2025
Contributor
Author
uros-db
left a comment
uros-db
left a comment
There was a problem hiding this comment.
@cloud-fan @mkaravel Please review.
cloud-fan
reviewed
Nov 6, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 6, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Nov 7, 2025
dongjoon-hyun
approved these changes
Nov 7, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @uros-db and @cloud-fan .
Merged to master/4.1.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 7, 2025
…graphyType(ANY) ### What changes were proposed in this pull request? This PR allows casting fixed SRID type `GEOGRAPHY(<srid>)` to mixed SRID type `GEOGRAPHY(ANY)`. ### Why are the changes needed? Enable explicit casting between geography types. ### Does this PR introduce _any_ user-facing change? Yes, casting `GEOGRAPHY(<srid>)` to `GEOGRAPHY(ANY)` is now allowed. ### How was this patch tested? Added new unit tests: - `StUtilsSuite` - `CastSuiteBase` Added new e2e SQL tests: - `st-functions` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52906 from uros-db/geo-cast-geography_any. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 941c24b) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR allows casting fixed SRID type
GEOGRAPHY(<srid>)to mixed SRID typeGEOGRAPHY(ANY).Why are the changes needed?
Enable explicit casting between geography types.
Does this PR introduce any user-facing change?
Yes, casting
GEOGRAPHY(<srid>)toGEOGRAPHY(ANY)is now allowed.How was this patch tested?
Added new unit tests:
StUtilsSuiteCastSuiteBaseAdded new e2e SQL tests:
st-functionsWas this patch authored or co-authored using generative AI tooling?
No.