fix: 'save and go to dashboard' option was disabled after changing the chart type

[richardfogaca]

SUMMARY

Fixes a bug where the "Save and go to dashboard" option becomes disabled after changing a chart's visualization type.

The Problem:
When a user opens a chart from a dashboard and changes its visualization type (e.g., Line Chart → Bar Chart), the dashboard context is lost. The Save modal then shows a placeholder "Select a dashboard OR create a new one" instead of the actual dashboard name, and the "Save & go to dashboard" option becomes disabled.

Root Cause:
The dashboardId field was being dropped during the form data transformation process when switching visualization types. This happened in standardizedFormData.ts where:

• dashboardId is not a form control, it's just a regular field that stores the dashboard context
• When getFormDataFromControls() builds the new form data, it only includes fields that have corresponding controls
• The dashboardId wasn't in the publicControls array (fields that should be preserved across viz changes)
• Even though public form data was collected, it was being overwritten instead of preserved

The Fix:
Two small changes to superset-frontend/src/explore/controlUtils/standardizedFormData.ts:

1. Added dashboardId to the publicControls array so it gets collected during transformations
2. Spread publicFormData after getFormDataFromControls() so the dashboard context is preserved and not overwritten

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE: After changing chart type, Save modal shows "Select a dashboard OR create a new one" and "Save & go to dashboard" is disabled and nothing shows on "Add to dashboard" field

AFTER: Save modal correctly displays the dashboard name and "Save & go to dashboard" remains enabled and "Add to dashboard" field shows the proper content

TESTING INSTRUCTIONS

1. Open a dashboard and click into one of its charts to open Explore view
2. Click Save and verify the dashboard name appears with "Save & go to dashboard" enabled (don't actually save)
3. Change the chart type to a different visualization (e.g., Line → Bar)
4. Click Save again
5. Verify the dashboard name still appears and "Save & go to dashboard" is still enabled

ADDITIONAL INFORMATION

• Changes UI

[bito-code-review]

Code Review Agent Run #5967e5

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 1293d84..1293d84

  • superset-frontend/src/explore/controlUtils/standardizedFormData.ts
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset-frontend/src/explore/controlUtils/standardizedFormData.ts	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[EnxDev]

Could we add some tests for this fix?

[richardfogaca]

Suggestions applied and tests added, thanks @alexandrusoare @EnxDev

[github-actions]

🎪 Showtime is building environment on GHA for 141edc3

[github-actions]

🎪 Showtime deployed environment on GHA for 141edc3

• Environment: http://52.37.62.176:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

[EnxDev]

LGTM!