fix(hydra): store and use hydra context in a local variable #6765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
valentin-dassonville
commented
Oct 30, 2024
valentin-dassonville
commented
| Q | A |
|---|---|
| Branch | 4.0 |
| License | MIT |
valentin-dassonville
force-pushed
the
fix/hydra-context-static-asset
branch
2 times, most recently
from
97db06a to
0454297
Compare
Contributor
|
@soyuka it seems to work on api-platform/demo#472 |
Member
|
Can't we merge the Hydra context in the context we generate? So we avoid an extra HTTP request. |
valentin-dassonville
force-pushed
the
fix/hydra-context-static-asset
branch
from
0a4dedf to
92009ff
Compare
valentin-dassonville
force-pushed
the
fix/hydra-context-static-asset
branch
from
92009ff to
36e4d08
Compare
valentin-dassonville
changed the title
dunglas
reviewed
Nov 5, 2024
features/hydra/docs.feature
Outdated
| And the JSON node "@context[0]" should be equal to: | ||
| """ | ||
| { | ||
| "@context": { |
Member
There was a problem hiding this comment.
I suggest doing something dynamic like:
- Download the original context from Hydra's website
- Assert that the context we generate is in sync with the upstream one
This will have the benefit of not bloating the tests and making the CI red if upstream changes the context.
WDYT?
| public function getResourceContextUri(string $resourceClass, int $referenceType = UrlGeneratorInterface::ABS_PATH): string; | ||
|
|
||
| public const HYDRA_CONTEXT = [ | ||
| '@context' => [ |
Member
There was a problem hiding this comment.
Maybe could we store this in an external PHP file that we automatically generate from the upstream JSON (so we can regenerate the file if needed).
soyuka
force-pushed
the
fix/hydra-context-static-asset
branch
from
ade6748 to
d24d2ce
Compare
soyuka
force-pushed
the
fix/hydra-context-static-asset
branch
from
d24d2ce to
a7e14dc
Compare
dunglas
approved these changes
Nov 6, 2024
Co-authored-by: Kévin Dunglas <[email protected]>
Member
|
Thanks @valentin-dassonville ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.