Skip to content

Conversation

@josedonizetti
Copy link
Collaborator

@josedonizetti josedonizetti commented Nov 6, 2025

This PR refactor the old flag --install-path to its new format --runtime workdir=.... This refactor also starts to introduce the format we want the flags package to look like.

  • All flags under pkg/corba/flags
  • Only one config representation to flag and config file
  • Test for flags, structured and unstructured config file
  • Constant to avoid repetition

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 46.55172% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.57%. Comparing base (034cbab) to head (84d51e6).
⚠️ Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
cmd/tracee/cmd/root.go 0.00% 13 Missing ⚠️
pkg/cmd/cobra/cobra.go 0.00% 10 Missing ⚠️
pkg/cmd/tracee.go 0.00% 8 Missing ⚠️

❌ Your patch check has failed because the patch coverage (46.55%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5021      +/-   ##
==========================================
+ Coverage   29.72%   30.57%   +0.84%     
==========================================
  Files         234      233       -1     
  Lines       26186    25992     -194     
==========================================
+ Hits         7785     7946     +161     
+ Misses      17864    17506     -358     
- Partials      537      540       +3     
Flag Coverage Δ
unit 30.57% <46.55%> (+0.84%) ⬆️
Files with missing lines Coverage Δ
pkg/cmd/flags/config.go 89.47% <100.00%> (+89.47%) ⬆️
pkg/cmd/flags/runtime.go 100.00% <100.00%> (ø)
pkg/cmd/tracee.go 0.00% <0.00%> (ø)
pkg/cmd/cobra/cobra.go 0.00% <0.00%> (ø)
cmd/tracee/cmd/root.go 0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josedonizetti josedonizetti force-pushed the newGeneralFlag branch 2 times, most recently from 5516c16 to 67c263c Compare November 8, 2025 13:46
@josedonizetti josedonizetti changed the title flag(general): new flag format flag(runtime): new flag format Nov 15, 2025
@josedonizetti josedonizetti force-pushed the newGeneralFlag branch 2 times, most recently from b673a4c to 048e55d Compare November 15, 2025 19:04
@josedonizetti josedonizetti force-pushed the newGeneralFlag branch 3 times, most recently from cf30996 to dcf5cf5 Compare November 25, 2025 02:11
@josedonizetti josedonizetti marked this pull request as ready for review November 25, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants