flag(runtime): new flag format #5021
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind/documentation
area/testing
area/UX
area/kubernetes
area/flags
labels
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5021 +/- ##
==========================================
+ Coverage 29.72% 30.78% +1.05%
==========================================
Files 234 236 +2
Lines 26186 26795 +609
==========================================
+ Hits 7785 8248 +463
- Misses 17864 18004 +140
- Partials 537 543 +6
🚀 New features to boost your workflow:
|
josedonizetti
force-pushed
the
newGeneralFlag
branch
2 times, most recently
from
5516c16 to
67c263c
Compare
josedonizetti
force-pushed
the
newGeneralFlag
branch
from
67c263c to
deab1cd
Compare
josedonizetti
changed the title
josedonizetti
force-pushed
the
newGeneralFlag
branch
2 times, most recently
from
b673a4c to
048e55d
Compare
josedonizetti
force-pushed
the
newGeneralFlag
branch
3 times, most recently
from
cf30996 to
dcf5cf5
Compare
josedonizetti
force-pushed
the
newGeneralFlag
branch
from
dcf5cf5 to
fa2caf5
Compare
josedonizetti
force-pushed
the
newGeneralFlag
branch
from
fa2caf5 to
dbdf56a
Compare
yanivagman
reviewed
Nov 25, 2025
josedonizetti
force-pushed
the
newGeneralFlag
branch
from
dbdf56a to
84d51e6
Compare
yanivagman
approved these changes
Nov 26, 2025
geyslan
reviewed
Dec 4, 2025
Member
geyslan
left a comment
geyslan
left a comment
There was a problem hiding this comment.
workdir as install-path are misleading to me. we should list what is written/read in such destination to better understand its purpose.
BREAKING CHANGE: add --runtime flag and remove --install-path
josedonizetti
force-pushed
the
newGeneralFlag
branch
from
84d51e6 to
b5f438a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the old flag
--install-pathto its new format--runtime workdir=.... This refactor also starts to introduce the format we want the flags package to look like.