Skip to content

Conversation

@brito-rafa
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@brito-rafa
Copy link
Contributor Author

This PR bumps K8s to the very latest version - v1.34.1. I do recommend creating a proper tag on the very latest https://github.com/argoproj/notifications-engine . I needed to point to the latest commit in order to make this work. @zachaller

@zachaller zachaller added this to the v1.9 milestone Oct 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Published E2E Test Results

  7 files    7 suites   6h 42m 34s ⏱️
117 tests 105 ✅  7 💤  5 ❌
857 runs  770 ✅ 49 💤 38 ❌

For more details on these failures, see this check.

Results for commit 51b6ba8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Published Unit Test Results

2 351 tests   2 351 ✅  3m 2s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit 51b6ba8.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.26%. Comparing base (5f59344) to head (51b6ba8).
⚠️ Report is 203 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4497      +/-   ##
==========================================
+ Coverage   82.69%   83.26%   +0.56%     
==========================================
  Files         163      164       +1     
  Lines       22895    23178     +283     
==========================================
+ Hits        18934    19299     +365     
+ Misses       3087     3018      -69     
+ Partials      874      861      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants