Upgrade eslint to V9 #592
Open
Upgrade eslint to V9 #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing all our explicit mentions of @typescript-eslint/ban-types (either to set it off or via disable comments), ESLint is no longer attempting to apply this specific rule in a context where its definition cannot be found for that particular file. This implies that one of the spread configurations (typescriptEslintPlugin.configs['flat/recommended-type-checked'] or reactPlugin.configs.flat.recommended) does enable @typescript-eslint/ban-types, and it's now being correctly applied (or not, if its internal file matching doesn't include this specific file for that rule, but critically, it's not erroring). The migration to ESLint v9 and flat config is now complete, and yarn lint passes. We can now progressively re-enable or fix the violations for the stricter type-aware rules (like no-unsafe-*, unbound-method, etc.) that we temporarily set to off in eslint.config.mjs (block argoproj#5).
By removing all our explicit mentions of @typescript-eslint/ban-types (either to set it off or via disable comments), ESLint is no longer attempting to apply this specific rule in a context where its definition cannot be found for that particular file. This implies that one of the spread configurations (typescriptEslintPlugin.configs['flat/recommended-type-checked'] or reactPlugin.configs.flat.recommended) does enable @typescript-eslint/ban-types, and it's now being correctly applied (or not, if its internal file matching doesn't include this specific file for that rule, but critically, it's not erroring). The migration to ESLint v9 and flat config is now complete, and yarn lint passes. We can now progressively re-enable or fix the violations for the stricter type-aware rules (like no-unsafe-*, unbound-method, etc.) that we temporarily set to off in eslint.config.mjs (block argoproj#5). Signed-off-by: Omer Azmon <[email protected]>
…into eslint-upgrade Signed-off-by: Omer Azmon <[email protected]>
Member
|
@linghaoSu would you be interested in taking a look at this? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Gemini 2.5 Pro and Cursor I have upgraded this repo to current eslint.
This does not fix any actual linting errors found.