Skip to content

Rename misleading variable in radix2 FFT #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename misleading variable in radix2 FFT #1048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions poly/src/domain/radix2/fft.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ impl<F: FftField> Radix2EvaluationDomain<F> {
// so we handle this in initialization, and reduce the number of loops that are performing arithmetic.
// The number of times we copy each initial non-zero element is as below:

let duplicity_of_initials = 1 << log_n.checked_sub(log_d).expect("domain is too small");
let duplication_factor = 1 << log_n.checked_sub(log_d).expect("domain is too small");

coeffs.resize(n, T::zero());

Expand All @@ -59,14 +59,14 @@ impl<F: FftField> Radix2EvaluationDomain<F> {
}

// duplicate initial values
if duplicity_of_initials > 1 {
ark_std::cfg_chunks_mut!(coeffs, duplicity_of_initials).for_each(|chunk| {
if duplication_factor > 1 {
ark_std::cfg_chunks_mut!(coeffs, duplication_factor).for_each(|chunk| {
let v = chunk[0];
chunk[1..].fill(v);
});
}

let start_gap = duplicity_of_initials;
let start_gap = duplication_factor;
self.oi_helper(&mut *coeffs, self.group_gen, start_gap);
}

Expand Down
Loading