Skip to content

Conversation

@jbedard
Copy link
Member

@jbedard jbedard commented Nov 10, 2025

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): yes
  • Suggested release notes appear below: yes

Remove support for PNPM versions 8 and lower. Only modern pnpm 9 and 10+ are supported.

Update the default pnpm version to ^10.0.

Test plan

  • Covered by existing test cases

@aspect-workflows
Copy link

aspect-workflows bot commented Nov 10, 2025

Bazel 7 (Test)

All tests were cache hits

291 tests (100.0%) were fully cached saving 49s.


Bazel 8 (Test)

All tests were cache hits

254 tests (100.0%) were fully cached saving 34s.


Bazel 7 (Test)

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 562ms.


Bazel 7 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 217ms.


Bazel 7 (Test)

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.


Bazel 7 (Test)

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 664ms.


Bazel 7 (Test)

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 596ms.


Bazel 7 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

3 tests (100.0%) were fully cached saving 564ms.


Bazel 7 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 582ms.


Bazel 7 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

3 tests (100.0%) were fully cached saving 231ms.


Bazel 7 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 180ms.


Bazel 7 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 34ms.


Bazel 7 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.


Bazel 7 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.


Bazel 7 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 367ms.


Bazel 7 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 105ms.


Bazel 7 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 313ms.


Bazel 7 (Test)

e2e/patch_from_repo

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/pnpm_lockfiles

All tests were cache hits

33 tests (100.0%) were fully cached saving 4s.


Bazel 7 (Test)

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 950ms.


Bazel 7 (Test)

e2e/pnpm_version

All tests were cache hits

1 test (100.0%) was fully cached saving 89ms.


Bazel 7 (Test)

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 3s.


Bazel 7 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 703ms.


Bazel 7 (Test)

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 2s.


Bazel 7 (Test)

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 454ms.


Bazel 7 (Test)

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 189ms.


Bazel 7 (Test)

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 118ms.


Bazel 7 (Test)

e2e/stamped_package_json

All tests were cache hits

1 test (100.0%) was fully cached saving 44ms.


Bazel 7 (Test)

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 78ms.


Bazel 7 (Test)

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/verify_patches

All tests were cache hits

2 tests (100.0%) were fully cached saving 109ms.


Bazel 7 (Test)

e2e/worker

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.


Bazel 7 (Test)

e2e/workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.


Buildifier      Format

@jbedard jbedard force-pushed the rm-pnpm-lt-9 branch 7 times, most recently from b83eeba to 5616a9f Compare November 10, 2025 08:34
@jbedard jbedard changed the base branch from main to 3.x November 10, 2025 20:18
@jbedard jbedard marked this pull request as ready for review November 10, 2025 21:52
@jbedard jbedard mentioned this pull request Nov 10, 2025
17 tasks
@jbedard jbedard force-pushed the rm-pnpm-lt-9 branch 2 times, most recently from a639dc4 to c602409 Compare November 10, 2025 22:10
commit = i.commit,
custom_postinstall = i.custom_postinstall,
deps = i.deps,
dev = i.dev_only,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also key. The npm_import(dev) and NpmPackageStoreInfo.dev flags are gone along with the npm_imported_package_store_internal(dev_only) and the struct(dev_only).

@dzbarsky dzbarsky merged commit 3dc8df0 into aspect-build:3.x Nov 11, 2025
2 checks passed
@jbedard jbedard deleted the rm-pnpm-lt-9 branch November 11, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants