Improve create-python-mirror - Save metadata & Update URLs #16475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plucia-mitre
force-pushed
the
plucia-mitre/create-python-mirror-improvements
branch
from
58952b4 to
e04e132
Compare
Author
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned in #12838, improve the
create-python-mirror.pyscript to (optionally) save filtered metadata with (optionally) updated URLs.This adds the following arguments:
--save-metadata [filepath]- Indicates metadata should be saved. If a file path is given after this argument the metadata is saved to the given file. If no path is given, the metadata is saved to the--targetargument value (or it's default value) with the filenamedownload-metadata.json.--mirror-url <url>- Updates URLs in the saved metadata to the given URL.Test Plan
Some ad-hoc testing has been performed. I'm not sure there's a more formal test procedure for this script.