Allow for unnormalized names in the METADATA file (#16547) #16548
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Deserialize project name into both a String and a ProjectName, this way we can keep using the normalized name elsewhere while respecting the original name from the `pyproject.toml` file
… `PyProjectToml`
| impl PyProjectToml { | ||
| pub(crate) fn name(&self) -> &PackageName { | ||
| &self.project.name | ||
| &self.project.name.1 |
Member
There was a problem hiding this comment.
I'd probably suggest adding a VerbatimPackageName struct with its own Deserialize implementation that stores the two.
charliermarsh
approved these changes
Nov 1, 2025
Member
|
Thanks! |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 10, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.7` -> `0.9.8` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.9.8`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#098) [Compare Source](astral-sh/uv@0.9.7...0.9.8) Released on 2025-11-07. ##### Enhancements - Accept multiple packages in `uv export` ([#​16603](astral-sh/uv#16603)) - Accept multiple packages in `uv sync` ([#​16543](astral-sh/uv#16543)) - Add a `uv cache size` command ([#​16032](astral-sh/uv#16032)) - Add prerelease guidance for build-system resolution failures ([#​16550](astral-sh/uv#16550)) - Allow Python requests to include `+gil` to require a GIL-enabled interpreter ([#​16537](astral-sh/uv#16537)) - Avoid pluralizing 'retry' for single value ([#​16535](astral-sh/uv#16535)) - Enable first-class dependency exclusions ([#​16528](astral-sh/uv#16528)) - Fix inclusive constraints on available package versions in resolver errors ([#​16629](astral-sh/uv#16629)) - Improve `uv init` error for invalid directory names ([#​16554](astral-sh/uv#16554)) - Show help on `uv build -h` ([#​16632](astral-sh/uv#16632)) - Include the Python variant suffix in "Using Python ..." messages ([#​16536](astral-sh/uv#16536)) - Log most recently modified file for cache-keys ([#​16338](astral-sh/uv#16338)) - Update Docker builds to use nightly Rust toolchain with musl v1.2.5 ([#​16584](astral-sh/uv#16584)) - Add GitHub attestations for uv release artifacts ([#​11357](astral-sh/uv#11357)) ##### Configuration - Expose `UV_NO_GROUP` as an environment variable ([#​16529](astral-sh/uv#16529)) - Add `UV_NO_SOURCES` as an environment variable ([#​15883](astral-sh/uv#15883)) ##### Bug fixes - Allow `--check` and `--locked` to be used together in `uv lock` ([#​16538](astral-sh/uv#16538)) - Allow for unnormalized names in the METADATA file ([#​16547](astral-sh/uv#16547)) ([#​16548](astral-sh/uv#16548)) - Fix missing value\_type for `default-groups` in schema ([#​16575](astral-sh/uv#16575)) - Respect multi-GPU outputs in `nvidia-smi` ([#​15460](astral-sh/uv#15460)) - Fix DNS lookup errors in Docker containers ([#​8450](astral-sh/uv#8450)) ##### Documentation - Fix typo in uv tool list doc ([#​16625](astral-sh/uv#16625)) - Note `uv pip list` name normalization in docs ([#​13210](astral-sh/uv#13210)) ##### Other changes - Update Rust toolchain to 1.91 and MSRV to 1.89 ([#​16531](astral-sh/uv#16531)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deserialize project name into both a String and a ProjectName, this way we can keep using the normalized name elsewhere while respecting the original name from the
pyproject.tomlfileThis PR addresses issue #16547
Test Plan
I added a new test for this, and I ran the test suite in the
metadata.rsfile.