-
Notifications
You must be signed in to change notification settings - Fork 0
UPSTREAM PR #17257: ggml-cpu : prevent kleidiai build/install targets #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
UPSTREAM PR #17257: ggml-cpu : prevent kleidiai build/install targets #205
Conversation
|
Access the complete analysis in the LOCI Dashboard Performance Analysis SummaryOverviewPull Request #205 addresses a CMake build system issue related to KleidiAI dependency management. The changes are isolated to build configuration and do not modify runtime code or core inference functionality. Performance Impact AssessmentHighest Performance Changes Detected:
Core Function Impact Analysis:
Tokens Per Second Impact: Power Consumption Analysis:
Flame Graph and CFG Analysis:
Code Review Findings: ConclusionThis build system fix introduces no performance regressions or functional changes. The minimal timing variations detected are within measurement precision limits and unrelated to the actual modifications made. The PR effectively addresses the stated installation issue while maintaining system performance and stability. |
88cd3fd to
c24d77f
Compare
* currently cmake install targets of kleidiai generate error * use `FetchContent_Populate` to disable all build/install targets of kleidiai * note that cmake would complains about the deprecation of `FetchContent_Populate` Signed-off-by: Yongjoo Ahn <[email protected]>
a02af4c to
2664317
Compare
|
Access the complete analysis in the LOCI Dashboard Performance Analysis SummaryOverviewThe analysis examined version Performance MetricsHighest Response Time Change:
Highest Throughput Change:
Power Consumption: Key FindingsCore Function Impact: None of the performance-critical inference functions ( Inference Performance: Token throughput remains unaffected as no core inference pipeline functions experienced meaningful changes. The sub-nanosecond variations in utility functions will not impact overall tokens per second performance. Technical Analysis:
Conclusion: The version update maintains stable performance characteristics with all changes falling within statistical noise levels. The build system improvements enhance deployment reliability without impacting inference performance. |
f333350 to
9c4623f
Compare
Mirrored from ggml-org/llama.cpp#17257
SOURCE_SUBDIRto explict invalid path as a bypassEXCLUDE_FROM_ALLwill do the same fix but it requires camke > v3.28.REF: https://discourse.cmake.org/t/prevent-fetchcontent-makeavailable-to-execute-cmakelists-txt/12704/3
Current install error log: