[V2]Reduce the compile time,by doing Multithreaded compilation #2973
Conversation
vrbagalkot
force-pushed
the
v2_blktest
branch
2 times, most recently
from
abb1045 to
863aa2f
Compare
Making use of built in functions to compile Signed-off-by: vrbagalkot <[email protected]>
|
|
@AYUSHJAIN951 Please review. |
AYUSHJAIN951
left a comment
AYUSHJAIN951
left a comment
There was a problem hiding this comment.
LGTM
Just please attach some more run logs, for code parts you are changing here.
| make_cmd = 'make -C %s %s -C %s run_tests' % ( | ||
| self.sourcedir, kself_args, test_comp) | ||
| self.result = process.run(make_cmd, shell=True, ignore_status=True) | ||
| args = '-C %s %s -C %s run_tests' % (self.sourcedir, kself_args, test_comp) |
There was a problem hiding this comment.
nit use f strings here as well, as you are using same in other changed parts
There was a problem hiding this comment.
f is being used in the below line.
There was a problem hiding this comment.
which is actually not even needed there, it can be just
args = " -C {self.sourcedir} {kself_args} -C {test_comp} run_tests"
self.result = build.run_make(path=self.sourcedir, extra_args=args)
There was a problem hiding this comment.
I think, you said, to use f string... Am I missing anything?
There was a problem hiding this comment.
aah sorry
args = f" -C {self.sourcedir} {kself_args} -C {test_comp} run_tests"
self.result = build.run_make(path=self.sourcedir, extra_args=args)
There was a problem hiding this comment.
I think, existing code should also be fine.
There was a problem hiding this comment.
I am fine with both, just attach some more logs, and I am good here
2 participants
Making use of built in functions to compile