lsslot output verify #3057
Open
lsslot output verify #3057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naresh-ibm
reviewed
Oct 9, 2025
| if self.run_cmd_out("lspci"): | ||
| self.run_cmd_out("lsslot -ac pci") | ||
| result = self.run_cmd("lsslot -ac pci", ignore_status=True) | ||
| self.assertEqual(result.exit_status, 0, "lsslot -ac pci failed") |
Collaborator
There was a problem hiding this comment.
@saijanani-c I feel just command return code is not enough and we need the validation of the command output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation to ensure lsslot -ac pci runs successfully and returns exit status 0