Test to verify the error injection feature of ndctl inject-smart for a pmem device. #3060
Conversation
|
[root@ltcblue9fq-lp12 memory]# avocado run --max-parallel-tasks=1 ndctl.py:NdctlTest.test_inject_SMART_errors -m ndctl.py.data/ndctl.yaml |
| self.ndctl = os.path.abspath('/usr/bin/ndctl') | ||
| self.daxctl = os.path.abspath('/usr/bin/daxctl') | ||
|
|
||
| def get_shutdown_state(self, region): |
memory/ndctl.py
Outdated
| self.daxctl = os.path.abspath('/usr/bin/daxctl') | ||
|
|
||
| def get_shutdown_state(self, region): | ||
| self.output = process.system_output('ndctl list -DH -r %s | grep shutdown_state' |
There was a problem hiding this comment.
you can use the cmd variable and re-use it, like below.
cmd = 'ndctl list -DH -r %s | grep shutdown_state' % region
self.output = process.system_output(cmd , sudo=True, shell=True)
memory/ndctl.py
Outdated
| self.output = process.system_output('ndctl list -DH -r %s | grep dev' | ||
| % region, sudo=True, shell=True) | ||
| process.system('ndctl inject-smart %s -U' % str(self.output).split("\"")[3], | ||
| sudo=True, shell=True) |
There was a problem hiding this comment.
same here, use cmd variable for easy indentation
memory/ndctl.py
Outdated
| self.output = process.system_output('ndctl list -DH -r %s | grep dev' | ||
| % region, sudo=True, shell=True) | ||
| process.system('ndctl inject-smart %s -N' % str(self.output).split("\"")[3], | ||
| sudo=True, shell=True) |
…a pmem device. This test does Err injection and check if shutdown_state changed to dirty and reverts the changes to clean state. Signed-off-by: Pavithra <[email protected]>
Pavithra1602
force-pushed
the
ndctl_errinject
branch
from
c399100 to
2afea1b
Compare
Naresh-ibm
left a comment
Naresh-ibm
left a comment
There was a problem hiding this comment.
@Pavithra1602 Thanks for incorporating the changes.
LGTM
2 participants
This test does Err injection and check if shutdown_state changed to dirty and reverts the changes to clean state.