Skip to content

Comments added for Translators in multiple files #9762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mehrazmorshed wants to merge 10,000 commits into
base: main
Choose a base branch
from
Open

Comments added for Translators in multiple files #9762

mehrazmorshed wants to merge 10,000 commits into from

Conversation

@mehrazmorshed
Copy link

@mehrazmorshed mehrazmorshed commented Oct 6, 2024

Adds #

Proposed Changes:

  1. Comments added for Translators in "includes/widgets.php"
  2. Comments added for Translators in "includes/class-edd-download.php"
  3. Comments added for Translators in "includes/api/class-edd-api-v2.php"
  4. Comments added for Translators in "includes/reports/reports-functions.php"
  5. Comments added for Translators in "includes/EDD_SL_Plugin_Updater.php"

cklosowski and others added 30 commits October 8, 2022 08:17
@cklosowski
Updating readme.txt
ad5d431
@robincornett
Create edd_has_core_blocks helper function
60d9c12 
awesomemotive#9496
@robincornett
Update edd_is_checkout to include a blocks check before filter
ffd5d82 
awesomemotive#9496
@robincornett
Update checkout related ajax calls to include current page
45b9fbf 
awesomemotive#9496
@robincornett
Update block editor author selection for download capabilities
7093d8f 
awesomemotive#9489
@cklosowski
Merge pull request awesomemotive#9500 from awesomemotive/issue/9489
c366b6a 
Update block editor author selection for download capabilities
@cklosowski
Limit the product_dropdown calls on the logs and main tools page to u…
12caa0c 
…se chosen awesomemotive#9498
@cklosowski
Add a permalink value to the products endpoint awesomemotive#9488
7db107e
@cklosowski
Update version matrix
f9ffe5d
@cklosowski
Merge pull request awesomemotive#9497 from awesomemotive/issue/9496
519f922 
Update edd_is_checkout logic
@cklosowski
Run permalink through html_entity_decode awesomemotive#9488
508555d
@cklosowski @zkawesome
Update tests/tests-api.php
412b934 
Co-authored-by: Žan K. <[email protected]>
@cklosowski
Merge pull request awesomemotive#9503 from awesomemotive/issue/9498
48377b8 
Limit the product_dropdown calls on the logs and main tools page to use chosen awesomemotive#9498
@cklosowski
Merge pull request awesomemotive#9505 from awesomemotive/issue/9488
0a9c3b7 
Add a permalink value to the products endpoint awesomemotive#9488
@robincornett
Update registration to account for registration block
9b2c0fc
@robincornett
Revert block input renaming
c156373
@cklosowski
Use graceful-shutdown to try and mitigate issues with IP space
4893385
@robincornett
Allow entire variable product to be selected for a bundle
ec38306 
awesomemotive#9499
@robincornett
Update edd_process_register_form, related unit tests
e09c251
@robincornett
When using the ajax product search, filter the posts_where string
9e72909 
awesomemotive#9508
@robincornett
Run search through esc_like
68e109a 
awesomemotive#9508
@cklosowski
Fixing product title on varaible price options in download ajax search …
b5a2453 
…awesomemotive#9508
@robincornett
Merge pull request awesomemotive#9509 from awesomemotive/issue/9508
26a1764 
Restrict the ajax downloads search to titles only
@robincornett
Update customer address migration
63b297c 
awesomemotive#9480
@robincornett
Prefix no-js class, add extra edd-has-js rule
76700bf
@robincornett
Update product selector for new bundles
48cf44d 
awesomemotive#9499
@robincornett
Fix type check
c5d34d4 
awesomemotive#9480
@robincornett
Fix inner query
950d5ed 
awesomemotive#9480
@zkawesome
Removed Carbon modify function
44831bc
@robincornett
Update customer names in exports
d6f372c
cklosowski and others added 28 commits November 9, 2023 17:09
@cklosowski
Adding 3.2.5
d977a24
@cklosowski
Merge pull request awesomemotive#9695 from awesomemotive/release/3.2.5
715373d 
Release 3.2.5
@cklosowski
Adding EDD 3.2.6
36f483b
@cklosowski
Merge pull request awesomemotive#9702 from awesomemotive/release/3.2.6
7e68d57 
Release 3.2.6
@cklosowski
Updating readme
92c97a3
@cklosowski
Adding release/3.2.7 lite changes
b2da430
@cklosowski
Merge pull request awesomemotive#9708 from awesomemotive/release/3.2.7
c848d0b 
Release 3.2.7
@cklosowski
Adding EDD 3.2.9
4c6c254
@cklosowski
Merge pull request awesomemotive#9711 from awesomemotive/release/3.2.9
e9c9f0a 
Release 3.2.9
@cklosowski
Adding EDD 3.2.10
490a49c
@cklosowski
Merge pull request awesomemotive#9717 from awesomemotive/release/3.2.10
4a09774 
Adding EDD 3.2.10
@cklosowski
Adding EDD 3.2.11
815fadf
@cklosowski
Merge pull request awesomemotive#9718 from awesomemotive/release/3.2.11
a788978 
Adding EDD 3.2.11
@cklosowski
Adding 3.2.12 changes
48834d6
@cklosowski
Merge pull request awesomemotive#9727 from awesomemotive/release/3.2.12
252a23a 
Adding 3.2.12 changes
@cklosowski
Adding EDD 3.3.0/1
64aa47f
@cklosowski
Merge pull request awesomemotive#9749 from awesomemotive/release/3.3.1
2e7c025 
Release 3.3.1 (Includes 3.3.0 changes)
@cklosowski
Adding EDD 3.3.2
feef716
@cklosowski
Merge pull request awesomemotive#9751 from awesomemotive/release/3.3.2
07c5f45 
Adding EDD 3.3.2
@cklosowski
Adding 3.3.3 changes
ee334bb
@cklosowski
Merge pull request awesomemotive#9753 from awesomemotive/release/3.3.3
a58152a 
Adding 3.3.3 changes
@cklosowski
Adding Release 3.3.4 changes
b26719d
@cklosowski
Merge pull request awesomemotive#9761 from awesomemotive/release/3.3.4
8bbd2be 
Adding Release 3.3.4 changes
@mehrazmorshed
modified includes/api/class-edd-api-v2.php
649aaa5
@mehrazmorshed
modified includes/widgets.php
e92ece2
@mehrazmorshed
modified includes/EDD_SL_Plugin_Updater.php
62f38cb
@mehrazmorshed
modified includes/reports/reports-functions.php
5bebd9f
@mehrazmorshed
modified includes/class-edd-download.php
c73bf1f
@slaFFik
Copy link
Member

slaFFik commented Nov 8, 2024

Hey @mehrazmorshed,

EDD uses a different syntax for that, not like you suggested in your PR:

/* translators: 1: opening anchor tag, do not translate 2. the new plugin version 3. closing anchor tag, do not translate. */

It's in the same includes/widgets.php file you modified, several lines above your suggestion.

EDD teams follows WordPress Codex suggestion: https://codex.wordpress.org/I18n_for_WordPress_Developers#Descriptions

So I think it might be a good idea to change all your // Translators: ... to a more appropriate in this repo /* translators: .... */.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mehrazmorshed @slaFFik @cklosowski @robincornett @zkawesome