-
Notifications
You must be signed in to change notification settings - Fork 179
feat: Add Support for Ready Condition #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Support for Ready Condition #210
Conversation
|
/retest |
Adding support for a Ready condition that is set after every reconciliation standardizes ACK's conditions. This condition will serve as a high level status check for users that want to use ACK alogside with other controllers (kro). The existing conditions will remain unchanged, and will still be set on the resource as they have been in the past. With this change, you'll be seeing a new condition that brings all our conditions together.
1413b4e to
e9d31f6
Compare
|
/test s3-controller |
|
@michaelhtm: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test s3-controller-test |
2 similar comments
|
/test s3-controller-test |
|
/test s3-controller-test |
|
/test ec2-controller-test |
|
/retest |
|
/test s3-controller-test |
|
/retest |
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
a-hilaly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
Adding support for a Ready condition that is set after every
reconciliation standardizes ACK's conditions.
This condition will serve as a high level status check for users that
want to use ACK alogside with other controllers (kro).
The existing conditions will remain unchanged, and will still be set on
the resource as they have been in the past. With this change, you'll be
seeing a new condition that brings all our conditions together.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.