Skip to content

Conversation

@michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Nov 6, 2025

Description of changes:
Adding support for a Ready condition that is set after every
reconciliation standardizes ACK's conditions.
This condition will serve as a high level status check for users that
want to use ACK alogside with other controllers (kro).

The existing conditions will remain unchanged, and will still be set on
the resource as they have been in the past. With this change, you'll be
seeing a new condition that brings all our conditions together.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and rushmash91 November 6, 2025 20:48
@ack-prow ack-prow bot added the approved label Nov 6, 2025
@michaelhtm
Copy link
Member Author

/retest

@michaelhtm michaelhtm changed the title Feat/addreadycondition feat: Add Support for Ready Condition Nov 7, 2025
Adding support for a Ready condition that is set after every
reconciliation standardizes ACK's conditions.
This condition will serve as a high level status check for users that
want to use ACK alogside with other controllers (kro).

The existing conditions will remain unchanged, and will still be set on
the resource as they have been in the past. With this change, you'll be
seeing a new condition that brings all our conditions together.
@michaelhtm michaelhtm force-pushed the feat/addreadycondition branch from 1413b4e to e9d31f6 Compare November 7, 2025 19:21
@michaelhtm
Copy link
Member Author

/test s3-controller

@ack-prow
Copy link

ack-prow bot commented Nov 7, 2025

@michaelhtm: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test ec2-controller-test
  • /test ecr-controller-test
  • /test iam-controller-test
  • /test s3-controller-test
  • /test sagemaker-controller-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test verify-attribution

Use /test all to run all jobs.

In response to this:

/test s3-controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelhtm
Copy link
Member Author

/test s3-controller-test

2 similar comments
@michaelhtm
Copy link
Member Author

/test s3-controller-test

@michaelhtm
Copy link
Member Author

/test s3-controller-test

@michaelhtm
Copy link
Member Author

/test ec2-controller-test

@michaelhtm
Copy link
Member Author

/retest

@michaelhtm
Copy link
Member Author

/test s3-controller-test

@michaelhtm
Copy link
Member Author

/retest

@ack-prow
Copy link

ack-prow bot commented Nov 8, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution e9d31f6 link false /test verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 39173f3 into aws-controllers-k8s:main Nov 8, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants