-
Notifications
You must be signed in to change notification settings - Fork 794
Extend static networking tests to include Ubuntu AMIs #3405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6863684 to
95ab4ff
Compare
| instanceType: c5.xlarge | ||
| desiredCapacity: 3 | ||
| amiFamily: UbuntuPro2404 | ||
| minSize: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: not sure why set min as max here?
|
Closing this as we have an open PR |
scripts/run-integration-tests.sh
Outdated
| START=$SECONDS | ||
|
|
||
| GINKGO_TEST_BUILD="$SCRIPT_DIR/../test/build" | ||
| TEST_IMAGE_REGISTRY=${TEST_IMAGE_REGISTRY:-"617930562442.dkr.ecr.us-west-2.amazonaws.com"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated change to point to public ecr..
What type of PR is this?
Which issue does this PR fix?:
What does this PR do / Why do we need it?:
Testing done on this change:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.