Add VPC sweeper for cleaning up orphaned test resources #3430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add vpc-sweeper.sh script to clean up test VPCs older than 7 days - Add GitHub workflow to run sweeper weekly on Sunday 9am PST - Add Makefile targets for vpc-sweeper and vpc-sweeper-force - Includes dry-run mode by default for safety
Contributor
|
will this script delete eks cluster created resources only or will also cleanup stale resources from cluster created through kops |
Contributor
Author
|
Collaborator
|
Can you please add testing details here ? Maybe run it against the test account to check if everything is getting cleaned up and add it here. Also this script does not cover kops clusters which gets leaked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
improvement
Which issue does this PR fix?:
Cron Jobs never run because VPC count is always exceeding quota. We need a sweeper that cleans up Stale VPCs and corresponding resources.
What does this PR do / Why do we need it?:
Cron Jobs never run because VPC count is always exceeding quota. We need a sweeper that cleans up Stale VPCs and corresponding resources.
Testing done on this change:
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.