feat: add customizable health probe configuration for helm chart #3495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guessi
force-pushed
the
feat/customizable-health-probe-config
branch
from
7c39b3c to
ad187b5
Compare
By adding `healthProbe.useCustomProbeConfig` flag to enable custom `grpc-health-probe` timeouts and `initialDelaySeconds` for both `liveness` and `readiness` probes while maintaining backward compatibility. Add healthProbe.useCustomProbeConfig flag to enable custom grpc-health-probe timeouts and initialDelaySeconds for liveness and readiness probes while maintaining backward compatibility.
guessi
force-pushed
the
feat/customizable-health-probe-config
branch
from
ad187b5 to
797c763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix?:
n/a
What does this PR do / Why do we need it?:
When it is about rolling version upgrade, a busy node or resource constraints node might required more time to complete health check, default
5smight not enough.By adding
healthProbe.useCustomProbeConfigflag to enable customgrpc-health-probetimeouts andinitialDelaySecondsfor bothlivenessandreadinessprobes while maintaining backward compatibility.Testing done on this change:
Will this PR introduce any new dependencies?:
n/a
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.