Node termination cleaner refactor and adding node id from node object #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haouc
reviewed
Jun 3, 2025
yash97
changed the title
haouc
reviewed
Jun 18, 2025
haouc
reviewed
Jun 18, 2025
haouc
reviewed
Jun 18, 2025
haouc
reviewed
Jun 18, 2025
haouc
reviewed
Jun 18, 2025
haouc
reviewed
Jun 18, 2025
haouc
reviewed
Jun 18, 2025
haouc
reviewed
Jun 18, 2025
haouc
reviewed
Jun 18, 2025
haouc
reviewed
Jun 18, 2025
haouc
reviewed
Jun 18, 2025
haouc
reviewed
Jun 18, 2025
yash97
force-pushed
the
node_cleaner
branch
2 times, most recently
from
1882683 to
322c69e
Compare
yash97
force-pushed
the
node_cleaner
branch
2 times, most recently
from
75017cd to
4e4245c
Compare
M00nF1sh
reviewed
Jun 27, 2025
yash97
added a commit
to yash97/amazon-vpc-resource-controller-k8s
that referenced
this pull request
Jun 30, 2025
…aws#567) * fetching instance id from k8s node object * refactored cninode controller, removed calling finalizer manager, handling all patches locally. * removing finalizer manager method * adding context and separate go routine to cleanup node resources
Merged
yash97
added a commit
that referenced
this pull request
Jun 30, 2025
…#567) * fetching instance id from k8s node object * refactored cninode controller, removed calling finalizer manager, handling all patches locally. * removing finalizer manager method * adding context and separate go routine to cleanup node resources
yash97
added a commit
to yash97/amazon-vpc-resource-controller-k8s
that referenced
this pull request
Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
For node termination cleaner fetching node instance id from node object and adding it to cninode for later use to filter eni by node id.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.