ignoring nodes with auto compute type #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subzidion
previously approved these changes
Sep 30, 2025
yash97
dismissed
Subzidion’s stale review
need to to change log level here as V(1) log will only get printed in debug level mode.
yash97
force-pushed
the
ignore_auto_nodes
branch
from
2311b3c to
6111dbd
Compare
Subzidion
approved these changes
Oct 1, 2025
yash97
added a commit
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
To not manage nodes, when node has label, for compute type auto. Right now user can edit node label and add label
vpc.amazonaws.com/has-trunk-attachedwhich will bypass vpc-rc check of cni node updated or not with SGPP. So vpc-rc will try to attach trunk interface to auto node.This PR ignores processing of node if label of compute type has value of auto.
Testing done
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.