generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 56
fix(integ-runner): inconsistent and unexpected CWD in test app execution #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iliapolo
merged 2 commits into
main
from
kornherm/fix/integ-runner/git-directory-handling
Nov 7, 2025
Merged
fix(integ-runner): inconsistent and unexpected CWD in test app execution #720
iliapolo
merged 2 commits into
main
from
kornherm/fix/integ-runner/git-directory-handling
Nov 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
- Coverage 83.91% 83.57% -0.34%
==========================================
Files 71 71
Lines 10401 10401
Branches 1326 1310 -16
==========================================
- Hits 8728 8693 -35
- Misses 1632 1669 +37
+ Partials 41 39 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
auto-merge was automatically disabled
July 16, 2025 12:27
Pull request was converted to draft
10a4550 to
d83463b
Compare
…ions Fixes issues with git operations by using the -C flag to specify the correct git repository directory. This ensures integ-runner works correctly when executed from outside the repository under test. Also standardizes the directory used for running CDK apps to always be the current working directory.
iliapolo
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the working directory being inconsistent and unexpected during execution of the test app. Previously we had two different behaviors: For regular execution we would execute the app from the directory of the test file, but for watch we would run it in the actual user's CWD. This is inconsistent behavior making it difficult to write integ test cases than can be executed across all modes.
Additionally as reported in #638, languages likes python may rely on the working directory to import modules. The working directory changing compared to library code and modes, makes it very difficult to use integ-runner in these languages.
This change aligns the working directory for test app execution to always be the CWD integ-runner is executed from. Given the two existing choices, this is the less arbitrary one and aligns more with how running a test app directly (
node integ.app-under-test.test.js) would work.The practical implications of this are limited. Tests are already discovered and executed using relative paths. In case someone really dependent on this behavior, they can simply execute integ-runner from a different working dir.
Fixes #638
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license