Skip to content

fix(cli): flag report is inconsistent with warnings #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rix0rrr merged 3 commits into from
Dec 1, 2025
Merged

fix(cli): flag report is inconsistent with warnings #967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
315d5e4
fix(cli): flag report is inconsistent with warnings
rix0rrr Nov 28, 2025
0a6bc07
Tests
rix0rrr Dec 1, 2025
9380450
Merge branch 'main' into huijbers/flags-inconsistent
rix0rrr Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions packages/aws-cdk/lib/cli/cdk-toolkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ import {
} from '../commands/migrate';
import type { CloudAssembly, CloudExecutable, StackSelector } from '../cxapp';
import { DefaultSelection, environmentsFromDescriptors, globEnvironmentsFromStacks, looksLikeGlob } from '../cxapp';
import { OBSOLETE_FLAGS } from '../obsolete-flags';
import {
deserializeStructure,
formatErrorMessage,
Expand All @@ -68,6 +67,7 @@ import { canCollectTelemetry } from './telemetry/collect-telemetry';
import { cdkCliErrorName } from './telemetry/error';
import { CLI_PRIVATE_SPAN } from './telemetry/messages';
import type { ErrorDetails } from './telemetry/schema';
import { FlagOperations } from '../commands/flags/operations';

// Must use a require() otherwise esbuild complains about calling a namespace
// eslint-disable-next-line @typescript-eslint/no-require-imports,@typescript-eslint/consistent-type-imports
Expand Down Expand Up @@ -2130,12 +2130,9 @@ export async function displayFlagsMessage(ioHost: IoHelper, toolkit: InternalToo
return;
}

const unconfiguredFlags = flags
.filter(flag => !OBSOLETE_FLAGS.includes(flag.name))
.filter(flag => (flag.unconfiguredBehavesLike?.v2 ?? false) !== flag.recommendedValue)
.filter(flag => flag.userValue === undefined);

const unconfiguredFlags = FlagOperations.filterNeedsAttention(flags);
const numUnconfigured = unconfiguredFlags.length;

if (numUnconfigured > 0) {
await ioHost.defaults.warn(`${numUnconfigured} feature flags are not configured. Run 'cdk flags --unstable=flags' to learn more.`);
}
Expand Down
Loading
Loading