Skip to content

Conversation

@ppittle
Copy link
Contributor

@ppittle ppittle commented May 13, 2025

Increase the robustness of GetBeforeSnapshotRequests. Create a unique feature collection on every warmup call.

Issue #, if available:
#2069

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…d exception disposing the context

(cherry picked from commit 7224bca5f8e6c95095daf4eed726fd02c7fad7f9)
Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the change file to the PR? Here is my stab at it but feel free to change it. Just be sure to include both Amazon.Lambda.AspNetCoreServer and Amazon.Lambda.AspNetCoreServer,Hosting in the change file.

{
  "Projects": [
    {
      "Name": "Amazon.Lambda.AspNetCoreServer",
      "Type": "Patch",
      "ChangelogMessages": [
        "Fixed issue when executing AddRegisterBeforeSnapshot callbacks to ensure each invocation has a new ASP.NET Core feature collection and HttpContext."
      ]
    },
    {
      "Name": "Amazon.Lambda.AspNetCoreServer.Hosting",
      "Type": "Patch",
      "ChangelogMessages": [
        "Update Amazon.Lambda.AspNetCoreServer dependency for latest patch fix."
      ]
    }
  ]
}

@ppittle
Copy link
Contributor Author

ppittle commented May 14, 2025

Apologies, I forgot about the changelog message. Took @normj's messages verbatim :)

@ppittle ppittle requested a review from normj May 14, 2025 19:45
@GarrettBeatty GarrettBeatty changed the base branch from master to dev May 14, 2025 20:11
@GarrettBeatty
Copy link
Contributor

ive updated the base branch to dev

@GarrettBeatty
Copy link
Contributor

GarrettBeatty commented May 14, 2025

Rerunning tests with correct branch. https://github.com/aws/aws-lambda-dotnet/actions/runs/15049599772

@GarrettBeatty GarrettBeatty merged commit 61c05b6 into aws:dev May 15, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants