Skip to content

Conversation

@SergeyRyabinin
Copy link
Contributor

@SergeyRyabinin SergeyRyabinin commented Dec 11, 2024

…lder GCC (#3216)"

This reverts commit 55372a2.

Issue #, if available:
the build of HEAD main is broken
reported by
55372a2#commitcomment-150189831

also the same issue is present internally:

error: '\\''Aws::Client::AWSError<Aws::Client::CoreErrors> Aws::Client::AWSErrorMarshaller::Marshall(const String&, const String&) const'\\'' is private within this context\n

Also the CRT submodule was accidentally reverted to an older hash of 0.29.3.
Description of changes:
Revert the merged PR.
Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin SergeyRyabinin merged commit 3a4fc06 into main Dec 11, 2024
5 checks passed
@SergeyRyabinin SergeyRyabinin deleted the sr/revert3216 branch December 11, 2024 07:02
sbera87 pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant