validating url for sso and sts #3610
Merged
+89
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
reviewed
Nov 5, 2025
| } | ||
| ss.str(); | ||
|
|
||
| Aws::Http::URI uri(ss.str()); |
Contributor
There was a problem hiding this comment.
instead of validating the the URI in the constructor, validate it when we make the call like how we currently do it in AwsClient, i.e. in AWSHttpResourceClient::GetResourceWithAWSWebServiceResult we should validate there before making any calls
| using namespace Aws::Auth; | ||
| using namespace Aws::Client; | ||
|
|
||
| class SSRFValidationTest : public Aws::Testing::AwsCppSdkGTestSuite { |
Contributor
There was a problem hiding this comment.
lets not make this its own test, AWSCredentialsProviderTest has tests for both SSO and STS, lets place tests there that validate this behavor
sbiscigl
approved these changes
Nov 5, 2025
sbiscigl
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: validating credential urls for sso and sts
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.