CBOR requests protocol test and extensions tests #3890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hy Version 1.58.0
peterrsongg
reviewed
Jun 23, 2025
...t-codegen/src/main/java/software/amazon/smithy/dotnet/codegen/HttpProtocolTestGenerator.java
Outdated
Show resolved
Hide resolved
...t-codegen/src/main/java/software/amazon/smithy/dotnet/codegen/HttpProtocolTestGenerator.java
Outdated
Show resolved
Hide resolved
...t-codegen/src/main/java/software/amazon/smithy/dotnet/codegen/HttpProtocolTestGenerator.java
Outdated
Show resolved
Hide resolved
sdk/test/ProtocolTests/AWSSDK.ProtocolTests.NetFramework.csproj
Outdated
Show resolved
Hide resolved
generator/ServiceClientGeneratorLib/Generators/Marshallers/CborResponseUnmarshaller.tt
Show resolved
Hide resolved
peterrsongg
approved these changes
Jun 23, 2025
Contributor
peterrsongg
left a comment
peterrsongg
left a comment
There was a problem hiding this comment.
Approving, made sure the protocol tests run succesfully and am aware that the unmarshaller.tt files are just placeholders for now
muhammad-othman
force-pushed
the
muhamoth/DOTNET-8157-cbor-requests-protocol-tests
branch
from
0007326 to
3f79895
Compare
boblodgett
approved these changes
Jun 27, 2025
| [InlineData("2025-06-19T20:15:28.468Z", 1750364128.468, CborReaderState.DoublePrecisionFloat, 10)] | ||
| public void WriteDateTime_EncodesCorrectly(string isoDate, double expectedUnixEpoch, CborReaderState expectedState, int expectedTotalBytes) | ||
| { | ||
| var dt = DateTime.Parse(isoDate).ToUniversalTime(); |
Contributor
There was a problem hiding this comment.
isoDate is already in UTC. You can parse it as such using:
DateTime.Parse(isoDate, CultureInfo.InvariantCulture, DateTimeStyles.AssumeUniversal | DateTimeStyles.AdjustToUniversal)
| writer.write("webResponseData.Headers[$S] = $S;", header, httpResponseTestCase.getHeaders().get(header)); | ||
| } | ||
| writer.write("byte[] bytes = Encoding.ASCII.GetBytes($S);", httpResponseTestCase.getBody()); | ||
| writer.write("byte[] bytes = Encoding.ASCII.GetBytes($S);", httpResponseTestCase.getBody()); |
Contributor
There was a problem hiding this comment.
Incorrect whitespace change / indentation.
…and Smithy v1.58.0
muhammad-othman
force-pushed
the
muhamoth/DOTNET-8157-cbor-requests-protocol-tests
branch
from
3f79895 to
ecde7e6
Compare
muhammad-othman
deleted the
muhamoth/DOTNET-8157-cbor-requests-protocol-tests
branch
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
DOTNET-8157DOTNET-8158Testing
DRY_RUN-e6b2cf96-b7e0-438b-b2a4-9df1826a5628Screenshots (if appropriate)
Types of changes
Checklist
License