Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/core/src/lambda/remoteDebugging/ldkClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,10 @@ export class LdkClient {
}

async deleteDebugVersion(functionArn: string, qualifier: string) {
if (!qualifier || qualifier === '$LATEST') {
// avoid deleting function directly
return true
}
try {
const region = getRegionFromArn(functionArn)
if (!region) {
Expand Down
18 changes: 18 additions & 0 deletions packages/core/src/test/lambda/remoteDebugging/ldkClient.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,24 @@ describe('LdkClient', () => {
assert(mockLambdaClient.deleteFunction.calledOnce, 'Should call deleteFunction')
})

it('should skip deletion when qualifier is empty or latest', async () => {
const result = await ldkClient.deleteDebugVersion(
'arn:aws:lambda:us-east-1:123456789012:function:testFunction',
''
)

const result2 = await ldkClient.deleteDebugVersion(
'arn:aws:lambda:us-east-1:123456789012:function:testFunction',
'$LATEST'
)
assert.strictEqual(result, true, 'Should return true without attempting deletion when empty')
assert.strictEqual(result2, true, 'Should return true without attempting deletion when latest')
assert(
mockLambdaClient.deleteFunction.notCalled,
'Should not call deleteFunction when qualifier is empty or latest'
)
})

it('should handle version deletion errors', async () => {
mockLambdaClient.deleteFunction.rejects(new Error('Delete failed'))

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "Remote debugging will not delete lambda function by accident if publish version failed"
}
Loading