-
Notifications
You must be signed in to change notification settings - Fork 264
Dev to SB #3157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sync (#3148) * feat(rule-engine): add fuzzy match score operator and update evaluation logic - Introduce FUZZY_MATCH_SCORE_LT as a new operation for rules - Modify BaseOperator to accept unifiedApiClient and threshold options - Update rule validation and execution to accommodate new operator functionality * feat(rule-engine): convert synchronous methods to asynchronous - Update BaseOperator's execute and validate methods to use async - Modify evaluation methods in operator classes to await execution - Ensure schema validations are handled asynchronously for improved performance * refactor(rule-engine): update rule engine functions for better async handling - Change validateRule function to return a Promise for async execution - Update runRuleSet to handle rules asynchronously with Promise.all - Rename RuleEngine to createRuleEngine for clarity in instantiation * refactor(rule-engine): simplify rule validation logic - Rename variable for clarity in validation result - Extract logic into helper functions for better readability - Improve threshold value handling for rules * fix(rule-engine): improve threshold validation and return handling - Ensure threshold is set to 80 by default in RuleSchema - Validate similarity score presence in response - Handle return from evaluate to ensure correct Promise resolution
* track page views * chore(monitoring): remove unused posthog import - Eliminate unused import of posthog-js in initialize-monitoring.ts - Update subproject commit hash in data-migrations * feat(auth): integrate analytics service for user login events - Add AnalyticsModule to track user login and magic link login events - Update AuthController to use analytics service for event tracking - Include necessary dependencies in package.json for analytics functionality * refactor(auth): update analytics event names to use EventNamesMap - Replace EventNames with EventNamesMap for consistency - Adjust method tracking for user login events - Update relevant imports and constructor parameter names across services * feat: pnpm-lock update * feat(tests): add AnalyticsModule to common testing modules - Include AnalyticsModule for enhanced testing capabilities - Ensure global availability of necessary services in tests * feat(tests): add analytics service to integration tests - Integrate AnalyticsService into collection-flow integration tests - Update dependencies in collection-flow controller tests to include AnalyticsService - Remove unused variable workflowDefinitionRepository in workflow definition service tests * feat(analytics): update customer created event with demo account flag - Modify AnalyticsEvents type to include isDemoAccount property - Update CustomerService to pass demo account status in analytics event - Update subproject commit reference in data-migrations folder --------- Co-authored-by: Tomer Shvadron <[email protected]>
* feat: added minimumAge validator * chore: ui bump * chore: cleanup * fix: updated tests & refactor * chore: lock fix * fix: fixed array like inputs to return undefined when value is empty * fix: fixed tests
* feat: documentfield & entitydocument field now using doc template to render label * chore: UI bump
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
No description provided.