fix: fixed issue where edit status was updated to in progress (#3425) #3426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: webhooks implementation & queue system * fix * wip worker * wip fixes * worker is up * finalized impl * fix circular * env.example * fix rebase conflicts * fix bug caused by rebase * trigger CI * add customer feature flag for opt-in queue system * fix: env schema * wip merge conflicts * fixes * lockfile * env example * Add Docker, Helm, and GitHub workflows for combined deployment * feat(metrics): add BullMQ metrics integration and dashboards - Introduce Prometheus metrics for BullMQ job states and integrate with OpenTelemetry - Set up Grafana dashboards for visualizing BullMQ performance metrics - Implement alerts and queuing system for better monitoring and job processing * refactor(workflows-service): clean up shutdown logic and remove unused types - Remove commented-out code related to graceful shutdown - Delete unused type declaration file for BullMQ OpenTelemetry integration * fix(monitoring): handle absence of BullMQ queues in Prometheus metrics export - Add a check for the existence of BullMQ queue before exporting metrics - Return a placeholder message if no queues are available - Remove the unused OpenTelemetry initialization module from the project * feat(workflows): improve configuration and queue management - Introduce specific environment configuration for worker module - Update Redis client configuration with max retries per request - Enhance job scheduler with job ID configuration to avoid multiple tasks in the cron queue * feat(monitoring): enhance metrics collection and docker configuration - Add Prometheus metrics endpoint for BullMQ queues - Configure Docker Compose for monitoring with Grafana and Prometheus - Register BullMQ queues in Prometheus service for comprehensive metrics tracking * refactor(env): change getEnvFilePath to an arrow function - Convert function declaration to arrow function syntax - Maintain existing functionality in retrieving environment file path * fix(queue): initialize Redis connection conditionally - Check if QUEUE_SYSTEM_ENABLED environment variable is set - Only initialize Redis connection when enabled * Revert "fix(queue): initialize Redis connection conditionally" This reverts commit 67a1997. * fix(queue): initialize Redis connection conditionally - Check if QUEUE_SYSTEM_ENABLED environment variable is set - Initialize Redis connection only when the feature is enabled * chore(docs): remove outdated BullMQ metrics and monorepo navigation documentation - Delete deprecated documentation files for BullMQ metrics implementation - Remove outdated monorepo navigation and command execution guidelines * fix(prometheus): remove public decorator from getMetrics endpoint - Eliminate the public decorator for enhanced security - Ensure metrics are accessible without public exposure * chore(metrics): remove obsolete Grafana dashboard configuration - Delete grafana-dashboard.json file as it is no longer needed - Streamline application code for clarity and maintainability fix(middleware): update request authorization checks for admin users - Ensure middleware correctly accesses user type from session - Improve security by preventing unauthorized access feat(metrics): add metrics endpoint for Prometheus status - Implement /prometheus endpoint to check metrics collection status - Enhance team visibility into system health with descriptive messaging * feat(middlewares): add metrics authentication middleware - Implement middleware to validate metrics token from request headers - Set up entity for metrics access if authentication is successful * refactor(queue): improve queue initialization logic and metrics handling - Rename and remove unnecessary metrics middleware from routes - Update Redis client configuration to allow unlimited retries per request - Enhance logging and setup checks for the queue system in relevant services * fix(workflows-service): correct alwaysApply setting in rules - Update alwaysApply to true for the workflows service rules - Ensure proper application of rules during service execution * update pnpm lock file --------- Co-authored-by: blokh <[email protected]> Co-authored-by: Sasha Mysak <[email protected]> Co-authored-by: Alon Peretz <[email protected]> Co-authored-by: Omer Harel <[email protected]>
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…3429) - Eliminate logging statements during the closure of queues and workers - Streamline the onModuleDestroy method for better clarity
* fix: fixed issue where edit status was updated to in progress (#3427) * feat: reworked final submission & added plugins output cleanup * fix: fixed types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.