MAJOR! Refactor bsp to class #278
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ShiningTrapez
left a comment
ShiningTrapez
left a comment
There was a problem hiding this comment.
LGTM, Like the use of extremely modern JS like class fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📺 What
Refactor BigscreenPlayer to a Javascript
Class.🛠 How
Changed BigscreenPlayer from function to
Class, updating tests accordingly.💡 Why
A step closer to implementing f.ex. the
EventTargetAPI. This removes the need for registered callbacks and plugins in their current usage. This feature (+@deprecated-ing allregisterCbandplugins) would be a good next step.✅ Testing
TBD
✅ Acceptance criteria
TBD