WIP: Add test for building meson project #141
Conversation
SeaDve
force-pushed
the
add-meson-building-test
branch
2 times, most recently
from
09faa1f to
69d5116
Compare
SeaDve
force-pushed
the
add-meson-building-test
branch
from
69d5116 to
def2421
Compare
SeaDve
force-pushed
the
add-meson-building-test
branch
from
def2421 to
e58e855
Compare
| @@ -0,0 +1,19 @@ | |||
| #!/usr/bin/env python3 | |||
|
|
|||
| from os import environ, path | |||
There was a problem hiding this comment.
Use the new meson post install, the less files we have for tests the better.
| @@ -0,0 +1,41 @@ | |||
| desktop_file = i18n.merge_file( | |||
There was a problem hiding this comment.
Do you need such sophisticated thing, we can just install_data and copy the file to the right directory, handling translations and validations are imho a bit out of scope of such a test case.
| ) | ||
| endif | ||
|
|
||
| appstream_file = i18n.merge_file( |
There was a problem hiding this comment.
Similarly here, do we even need an appdata file?
| ) | ||
| endif | ||
|
|
||
| install_data('some.meson.Project.gschema.xml', |
There was a problem hiding this comment.
The gschema should definitely be removed
|
|
||
|
|
||
|
|
||
| subdir('data') |
There was a problem hiding this comment.
I would avoid using subdirs, just put all the necessary files for the test on the same directory.
| "modules": [ | ||
| { | ||
| "name": "meson", | ||
| "builddir": true, |
There was a problem hiding this comment.
I don't think we actually handle the builddir argument in flatpak-vscode it is mostly used by builder to whether build stuff in current directory or do so in the cache directory.
| sys.path.insert(1, pkgdatadir) | ||
|
|
||
| if __name__ == '__main__': | ||
| from meson import main |
There was a problem hiding this comment.
just do the print call here and drop the other file?
|
For #129 we can only fix it if the source uses a dir as a source type, then we could get the basename of |
| "sources": [ | ||
| { | ||
| "type": "dir", | ||
| "url": "." |
There was a problem hiding this comment.
| "url": "." | |
| "path": "." |
2 participants
Related with #140
WIP since not working currently
flatpakprobably in CI