-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-27619] assign tasks component #17125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+831
โ303
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
e09eaa6
feat(dirt): add newApplications$ observable to orchestrator
AlexRubik 2c09085
feat(dirt): add saveApplicationReviewStatus$ to orchestrator
AlexRubik 1846293
feat(dirt): expose newApplications$ in data service
AlexRubik 3fc8928
feat(dirt): make AllActivitiesService reactive to new applications
AlexRubik 6d2d8ea
feat(dirt): connect dialog to review status save method
AlexRubik 245f956
feat(dirt): add i18n strings for application review
AlexRubik 7a29406
fix(dirt): add subscription cleanup to AllActivitiesService
AlexRubik b1da2cb
fix(dirt): replace manual takeUntil with takeUntilDestroyed in AllActโฆ
AlexRubik 907a784
refactor(dirt): remove newApplications from OrganizationReportSummary
AlexRubik 8340dc2
cleanup
AlexRubik cf15d25
fix(dirt): improve dialog type safety and error logging
AlexRubik bf1c415
Merge branch 'main' into dirt/pm-27284/new-applications-card-real-data
AlexRubik 6912be9
fixing mock data and test cases for new apps
ttalty 5d37ede
feat(dirt): create assign tasks view component
AlexRubik eb74aa2
refactor(dirt): add multi-view state management to new applications dโฆ
AlexRubik b5fdcda
feat(dirt): integrate assign tasks view into dialog
AlexRubik a928399
feat(dirt): add embedded assign tasks view to dialog template
AlexRubik a1ee9f1
feat(dirt): add i18n keys for assign tasks view
AlexRubik c449442
resolve organizationId and DI issues in assign tasks flow
AlexRubik 286d50a
Merge branch 'main' into dirt/pm-27619/assign-tasks-dialog
AlexRubik f3d87e7
cleanup styling
AlexRubik 580981e
refactor(dirt): remove newApplications validation from OrganizationReโฆ
AlexRubik ed283f1
Merge branch 'dirt/pm-27284/new-applications-card-real-data' into dirโฆ
AlexRubik 08df1ea
improve assign tasks view display
AlexRubik 8d99996
logic to fetch totals and new styling
AlexRubik 22b18ae
Merge branch 'main' into dirt/pm-27619/assign-tasks-dialog
AlexRubik ba4c3e2
Merge branch 'main' into dirt/pm-27619/assign-tasks-dialog
AlexRubik 3050da1
Merge branch 'main' into dirt/pm-27619/assign-tasks-dialog
AlexRubik ec4855c
Fix review applications review view and assign view flow
Banrion 41d02bb
Fix null type checks
Banrion b9c9737
refactor assign tasks dialog: use callout component, add video, fix Oโฆ
maxkpower 831cf53
Add columns, description, search, and bulk select to new applicationsโฆ
maxkpower f7534a7
Add count placeholder for critical applications marked message
maxkpower 7aa3cf4
Merge branch 'main' into dirt/pm-27619/assign-tasks-dialog
maxkpower 185e639
Merge branch 'main' into dirt/pm-27619/assign-tasks-dialog
Banrion 1dd92f8
Address claude comments
Banrion 32dd082
Merge remote-tracking branch 'refs/remotes/origin/dirt/pm-27619/assigโฆ
Banrion bdda6e9
Merge branch 'main' into dirt/pm-27619/assign-tasks-dialog
maxkpower File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ค The size difference in these two video files surprise me. Is one compressed or built upon the other somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, one was attached as .mov to the ticket so I converted with ffmpeg. Will check / optimise