Desktop Native remove log deps

[neuronull]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26090

📔 Objective

As part of #16321 , removing the log deps from the tree.

A subsequent PR will be made to add automated checks for re-adding of the log crate.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 861f368b-e3d2-4b9e-97a6-e9a80f89f4f4

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.41%. Comparing base (1e5c0ac) to head (92c558c).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17135      +/-   ##
==========================================
- Coverage   40.45%   40.41%   -0.05%     
==========================================
  Files        3503     3504       +1     
  Lines      100022   100142     +120     
  Branches    15000    15017      +17     
==========================================
+ Hits        40461    40468       +7     
- Misses      57844    57956     +112     
- Partials     1717     1718       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[claude]

Claude finished @neuronull's task —— View job

---

Code Review Complete

Summary of Changes

This PR removes the legacy log crate dependencies from the desktop_native workspace as the final cleanup step of the migration to tracing (completed in #16321). The changes remove:

1. Root Cargo.toml: Removed log, oslog, and simplelog dependencies
2. macos_provider/Cargo.toml: Moved tracing-oslog from general dependencies to macOS-specific target dependencies and removed oslog
3. Cargo.lock: Removed transitive dependencies (dashmap, hashbrown 0.14.5, and oslog)

---

Critical Issues

None found. ✅

---

Suggested Improvements

📝 Minor: Dependency Reorganization Logic

File: apps/desktop/desktop_native/macos_provider/Cargo.toml:23-28

The change moves tracing-oslog from general dependencies to the [target.'cfg(target_os = "macos")'.dependencies] section while simultaneously removing oslog. This is actually a positive improvement since tracing-oslog is macOS-specific, but it wasn't explicitly mentioned in the PR description.

Recommendation: Consider mentioning this reorganization in the PR description or commit message, as it's not just a removal but also an optimization (the dependency is now only included on macOS builds).

🤔 Future Consideration: Workspace Dependency Management

The root Cargo.toml currently doesn't define tracing-oslog in [workspace.dependencies] even though it's used in a workspace member. This is fine since it's only used in one place and is platform-specific, but for consistency with other dependencies, you might consider adding it to the workspace definition in a future PR.

---

Good Practices Observed

• Clean removal without leaving orphaned code
• All logging still works via tracing macros throughout the codebase
• Platform-specific dependency correctly moved to target-specific section
• Proper dependency tree cleanup (transitive deps removed from Cargo.lock)

---

Action Items

None required. This PR is ready to merge. ✅

The changes are minimal, focused, and accomplish the stated objective. All CI checks have passed, and there are no remaining references to the removed crates in the codebase.

---