[Video-2230] Build in Windows #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
ha! looks like the preprocessor definitions I added to get this to build in Windows is causing it to fail in Ubuntu. |
saraboule
commented
Jun 30, 2023
saraboule
commented
Jun 30, 2023
saraboule
requested review from
a team and
btgoodwin
and removed request for
a team
somehow I accidentally overwrote this line.
lyramcmillan
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video-2230
During the process of developing -- https://blinemedical.atlassian.net/browse/VIDEO-2183, it was realized that the s3sink no longer built in Windows the main crux of the issue is due to the fact this PR for the aws-sdk-cpp is still open: aws/aws-sdk-cpp#1839
Currently, I am forking the aws-sdk-cpp and adding in those changes to appropriate cmake files. I was also having issues with the meson.build file -- it took in different cpp_args for Windows and in Linux. You will have to build our fork of the sdk in order to get this to build in Windows.