Skip to content

refactor: remove use of cbor.DecodeGeneric #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
+8 −2
Merged

refactor: remove use of cbor.DecodeGeneric #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions internal/indexer/datum.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (

// DNSReferenceRefScriptDatum represents the auto-discovery datum type for scripts that handle DNS records
type DNSReferenceRefScriptDatum struct {
// This allows the type to be used with cbor.DecodeGeneric
cbor.StructAsArray
TldName []byte
SymbolDrat []byte
Expand Down Expand Up @@ -56,5 +55,12 @@ func (d *DNSReferenceRefScriptDatum) UnmarshalCBOR(cborData []byte) error {
tmpDataInner.Constructor(),
)
}
return cbor.DecodeGeneric(tmpDataInner.FieldsCbor(), d)
// Decode constr field data without using our custom decode function
type tDNSReferenceRefScriptDatum DNSReferenceRefScriptDatum
var tmpScriptDatum tDNSReferenceRefScriptDatum
if _, err := cbor.Decode(tmpDataInner.FieldsCbor(), &tmpScriptDatum); err != nil {
return err
}
*d = DNSReferenceRefScriptDatum(tmpScriptDatum)
return nil
}
Loading