Windows fixes #8727
Draft
Windows fixes #8727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8727 +/- ##
==========================================
- Coverage 81.43% 81.09% -0.35%
==========================================
Files 77 77
Lines 13515 13523 +8
Branches 2004 2004
==========================================
- Hits 11006 10966 -40
- Misses 1853 1891 +38
- Partials 656 666 +10 ☔ View full report in Codecov by Sentry. |
Closed
ThomasWaldmann
force-pushed
the
windows-fixes
branch
2 times, most recently
from
4d1c369 to
d415916
Compare
ThomasWaldmann
force-pushed
the
windows-fixes
branch
from
d415916 to
13f2fed
Compare
Member
Author
|
@sothix I rebased this on current master now. Likely it will still fail due to the windows-specific |
ThomasWaldmann
force-pushed
the
windows-fixes
branch
2 times, most recently
from
0001678 to
ef7e284
Compare
Not as simple as it looks at first, especially if Windows drive letter come into play.
ThomasWaldmann
force-pushed
the
windows-fixes
branch
from
ef7e284 to
d16351d
Compare
Merged
valtron
reviewed
Oct 31, 2025
Contributor
valtron
left a comment
valtron
left a comment
There was a problem hiding this comment.
Looks good, forgot about .as_uri. You can also remove _local_abspath_to_uri then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.