Skip to content

Conversation

@hsnprsd
Copy link
Contributor

@hsnprsd hsnprsd commented Nov 2, 2025

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #0000 | Relates #0000

@hsnprsd hsnprsd marked this pull request as ready for review November 2, 2025 12:14
@hsnprsd hsnprsd force-pushed the use-ubuntu-minimal-cloud-image-in-tests branch from 4a61e6e to 634aaad Compare November 2, 2025 12:19
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 2, 2025
@hsnprsd
Copy link
Contributor Author

hsnprsd commented Nov 2, 2025

My life would be simpler with a leaner cloud image. 😆

@shamilovstas
Copy link
Contributor

Maybe something similar can be done for lxc tests as well? Containers use templates from http://download.proxmox.com and there are no minimal builds for Ubuntu there, but maybe it is possible to use Alpine templates instead? Its ~140 MB -> ~ 3 MB size reduction

@hsnprsd hsnprsd force-pushed the use-ubuntu-minimal-cloud-image-in-tests branch from 634aaad to c2e9ef4 Compare November 5, 2025 06:02
@bpg bpg changed the title misc: use ubuntu minimal cloud image in tests misc(test): use ubuntu minimal cloud image in tests Nov 7, 2025
@bpg
Copy link
Owner

bpg commented Nov 7, 2025

Good call updating the tests!

Not sure about the changes in docs and guides tho. People come here from different backgrounds, and many may start with copy/pasting an example, which may not produce a VM they expect.

Also I remember some issues in 22.04 vs 24.04 around cloud-init and/systemd behaviour in new versions, some examples might require additional adjustments, like adding serial device, or something.
Need to double check them to make sure they all still work before releasing this. @hsnprsd not sure if you ran them, proof of work of the PR doesn't say anything 🤷🏼

@hsnprsd
Copy link
Contributor Author

hsnprsd commented Nov 9, 2025

I ran several tests, but not all of them—I don’t remember exactly which ones :). I’m fine with reverting the documentation changes.

@hsnprsd hsnprsd force-pushed the use-ubuntu-minimal-cloud-image-in-tests branch from 1518426 to e955290 Compare November 9, 2025 18:21
@pull-request-size pull-request-size bot added size/S and removed size/M labels Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants